StreamShop App #953
StreamShop App #953
Conversation
Tagging OptionsShould a new tag be published when this PR is merged?
|
streamshop/sections/Stories.tsx
Outdated
| interface Props extends SectionHeaderProps { | ||
| /** | ||
| * @title Slug Videos | ||
| * @description Slug separados por vírgula - dBXLVDZM,B9hKEmHZ,... | ||
| */ | ||
| slugs: string; | ||
| } |
There was a problem hiding this comment.
I think a string[] its a better UX aproach
| interface Props extends SectionHeaderProps { | |
| /** | |
| * @title Slug Videos | |
| * @description Slug separados por vírgula - dBXLVDZM,B9hKEmHZ,... | |
| */ | |
| slugs: string; | |
| } | |
| interface Props extends SectionHeaderProps { | |
| /** | |
| * @title Slug Videos | |
| */ | |
| slugs: string[]; | |
| } |
streamshop/sections/Stories.tsx
Outdated
| slugs = | ||
| "lnSWxBFj,E5hUMpXl,o8GbO1r7,g31wys57,4J8mqGAD,Q41wyj80,NJ6WxSZp,lCx1dr89,ZI2NBKS7,ximkLtuV,AG6Fhvn0,YLohX8FM,lUwLnDpx,5ur2WIIU,PdfbAvpP", |
There was a problem hiding this comment.
This slugs are sample slugs of the app that works in any app account? If its not maybe this should be removed
| slugs = | |
| "lnSWxBFj,E5hUMpXl,o8GbO1r7,g31wys57,4J8mqGAD,Q41wyj80,NJ6WxSZp,lCx1dr89,ZI2NBKS7,ximkLtuV,AG6Fhvn0,YLohX8FM,lUwLnDpx,5ur2WIIU,PdfbAvpP", | |
| slugs = [] |
There was a problem hiding this comment.
Yes, these are example slugs.
streamshop/sections/Carousel.tsx
Outdated
There was a problem hiding this comment.
Change to slug to string[]
| > | ||
| <div | ||
| class="relative bg-base-200 mx-5 sm:mx-0" | ||
| hx-on:click="openStreamShopLive('https://live.hml.streamshop.com.br/trident/loja?v=WSkU9DFr')" |
There was a problem hiding this comment.
Should this string really be hard-coded? Is nothing changing between stores?
streamshop/sections/Embed.tsx
Outdated
| { | ||
| /* <div | ||
| style={{ | ||
| display: "inline-block", | ||
| height: "auto", | ||
| cursor: "pointer", | ||
| overflow: "hidden", | ||
| borderRadius: "0px" | ||
| }} | ||
| hx-on:click="openStreamShopLive('https://live.hml.streamshop.com.br/trident/loja?v=WSkU9DFr')">AQUI</div> */ | ||
| } |
There was a problem hiding this comment.
| { | |
| /* <div | |
| style={{ | |
| display: "inline-block", | |
| height: "auto", | |
| cursor: "pointer", | |
| overflow: "hidden", | |
| borderRadius: "0px" | |
| }} | |
| hx-on:click="openStreamShopLive('https://live.hml.streamshop.com.br/trident/loja?v=WSkU9DFr')">AQUI</div> */ | |
| } |
| src={storeSlug | ||
| ? `https://lite.streamshop.com.br/${storeSlug}` | ||
| : "https://lite.streamshop.com.br/streamshopdemo"} |
There was a problem hiding this comment.
maybe only change storeSlug to has 'streamshopdemo' as default value
streamshop/actions/myAction.ts
Outdated
There was a problem hiding this comment.
I think this file is a app template demo file, you should delete it
streamshop/loaders/myLoader.ts
Outdated
There was a problem hiding this comment.
I think this file is a app template demo file, you should delete it
streamshop/utils/client.ts
Outdated
There was a problem hiding this comment.
I think this file is a app template demo file, you should delete it
streamshop/utils/types.ts
Outdated
There was a problem hiding this comment.
I think this file is a app template demo file, you should delete it
| * @title Stream shop app | ||
| * @description Integration of streamshop services. | ||
| * @category Tools | ||
| * @logo https:// |
There was a problem hiding this comment.
maybe you could add the logo
| @@ -0,0 +1 @@ | |||
| # Stream Shop Readme | |||
There was a problem hiding this comment.
Please improve README description.
There was a problem hiding this comment.
Why this file exists? Remove it or use a better filename and description.
|
|
||
| /** | ||
| * This component renders the filter and selectors for skus. | ||
| * TODO: Figure out a better name for this component. |
There was a problem hiding this comment.
This seems like a unnecessary lint change. please revert.
There was a problem hiding this comment.
Why this file exists? remove it if not used.
There was a problem hiding this comment.
Where is this file used? Remove it otherwise.
There was a problem hiding this comment.
Where is this file used? Remove it otherwise.
There was a problem hiding this comment.
Where is this file used? Remove it otherwise.
There was a problem hiding this comment.
Where is this file used? Remove it otherwise.
There was a problem hiding this comment.
Where is this file used? Remove it otherwise.
What is this Contribution About?
A new app to integration streamshop services.
https://vimeo.com/1022990110/a00bec4ebf?share=copy
Demonstration Link
https://sites-streamshop--staging.decocdn.com/