-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fix vale errors #152
base: develop
Are you sure you want to change the base?
Conversation
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
…documentation-1 into implement-vale-linter
@RCheesley I see lots of conflicts here, maybe we can start a new one from develop and cherry-pick what we need from this branch? |
Sure thing, it's quite a big task hence why it's taking so long! |
@RCheesley drive by comment to say that even if the |
Hi folks!
🚧 WIP - still working on this PR.
👋 Intro
🤔 What's it doing?
This is a pretty monster PR which fixes a whole lot of spelling, grammar and other related issues.
NOTE: This does not address gendered terms, I was asked to split that into a separate PR - #151.
There are some general points which I've highlighted below and fixed project-wide:
🚨 Things I came across while working on this PR
💡 Core changes we should recommend before changing in the docs
In these cases, I've had to use a command to turn off the failing Vale rules for the relevant blocks and then turn them back on again. These are strings from core, so I can't just change them in the docs as it wouldn't make sense to the user seeing something different in the application.