Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Modes #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Style Modes #14

wants to merge 1 commit into from

Conversation

JaceHensley
Copy link
Collaborator

closes #2

@JaceHensley JaceHensley changed the title Add initial styling modes Style Modes Apr 13, 2022
"definitions": {
"styles": {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open to suggestions on better structuring of the schema

How I'd write the TS types:

type Image = {
  uri: string
  alt: string
}

type Color = {
  color: string
}

type BaseESD = {
  thumbnail: Image
  hero: Image
  background: Color
  text: Color
}

type StyleMode = {
  mode: string
  styles: BaseESD
}

type BasicESD = BaseESD & {
  style_mode: StyleMode
}

type ThemedESD = {
  light: BasicESD
  dark: BasicESD
}

type ESD = BasicESD | ThemedESD

@JaceHensley JaceHensley marked this pull request as ready for review May 26, 2022 16:46
@brentzundel brentzundel added this to the v2 milestone Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet Rendering Entity Styles Discussion
2 participants