Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more logging and tracing #183

Merged
merged 2 commits into from
Apr 12, 2024
Merged

add more logging and tracing #183

merged 2 commits into from
Apr 12, 2024

Conversation

decentralgabe
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 38.00000% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 54.01%. Comparing base (9526dd8) to head (3e4a15b).

Files Patch % Lines
impl/pkg/server/logging.go 0.00% 18 Missing ⚠️
impl/pkg/service/pkarr.go 66.66% 2 Missing and 3 partials ⚠️
impl/pkg/telemetry/telemetry.go 0.00% 4 Missing ⚠️
impl/internal/util/logging.go 0.00% 2 Missing ⚠️
impl/cmd/main.go 0.00% 1 Missing ⚠️
impl/integrationtest/main.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   54.11%   54.01%   -0.10%     
==========================================
  Files          32       32              
  Lines        2515     2540      +25     
==========================================
+ Hits         1361     1372      +11     
- Misses       1018     1029      +11     
- Partials      136      139       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@decentralgabe decentralgabe merged commit 2ba13d4 into main Apr 12, 2024
4 of 5 checks passed
@decentralgabe decentralgabe deleted the better-cachcing branch April 12, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants