-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consolidate appendix examples #159
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
Updated the JWT representations with their new values from their appropriate appendix-jwt.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
The previous value was completely incorrect and didn't represent the JWT representation counterpart. Some changes include the correct placement and value of manifest_id
and correct values for descriptor_map[x].id
to have the same values as those in the manifest input_descriptors[x].id
.
Also exported the VC payload out the JWT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
Used the credential-application/appendix-jwt.json
to update the values so they more closely resemble the examples in the section, these include also the descriptor IDs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
As it can be seen, the previous value was for credential_application
object. Updated the value from the JWT in the spec. No other changes to the JWT were made.
This change fixes #154
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
Update the values of the descriptor_map[x].id
to match those of the manifest's output_descriptors[x].id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
Just fixed the incorrect manifest_id
ACKing in support |
This PR consolidates the examples stated in the Appendix section of the spec. Check comments on files for what has been wrong and what has changed in them.
Fixes #154