Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initial loading events #3376

Merged
merged 1 commit into from
Feb 20, 2025
Merged

fix: initial loading events #3376

merged 1 commit into from
Feb 20, 2025

Conversation

mihakrajnc
Copy link
Contributor

@mihakrajnc mihakrajnc commented Feb 17, 2025

Pull Request Description

What does this PR change?

Fixes initial loading analytics events:

Fixed order:

  • 2 - dynamic container loaded -> 3 - dynamic container loaded
  • 3 - feature flag initialized -> 2 - feature flag initialized

Fixed initial_loading events:

  • 7.0.X has been removed
  • 7.X are now ordered correctly and without gaps 7.0 - 7.8

Test Instructions

Prerequisites

None

Test Steps

  1. Smoke test
  2. Ensure initial_loading events are all in order (probably doesn't need QA approval)

Additional Testing Notes

  • Note any edge cases to verify
  • Mention specific areas that need careful testing
  • List known limitations or potential issues

Quality Checklist

  • Changes have been tested locally
  • Documentation has been updated (if required)
  • Performance impact has been considered
  • For SDK features: Test scene is included

Code Review Reference

Please review our Code Review Standards before submitting.

@mihakrajnc mihakrajnc requested review from a team as code owners February 17, 2025 12:21
Copy link

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ PR reviewed and approved by QA on both platforms following instructions playing both happy and un-happy path

Regressions for this ticket had been performed in order to verify that the normal flow is working as expected:

  • ✅ Log In/Log Out
  • ✅ Backpack and wearables in world
  • ✅ Emotes in world and in backpack
  • ✅ Teleport with map/coordinates/Jump In
  • ✅ Chat and multiplayer
  • ✅ Profile card
  • ✅ Camera
  • ✅ Skybox
  • ✅ Settings

Copy link
Collaborator

@popuz popuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 🦅 Neat idea about this enum approach ;)

@mihakrajnc mihakrajnc merged commit 043d186 into dev Feb 20, 2025
11 of 12 checks passed
@mihakrajnc mihakrajnc deleted the fix/login_analytics_tracking branch February 20, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants