fix: Wrong navigation when we click on map markers #3230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below. |
github-actions
bot
requested review from
Ludmilafantaniella,
mikhail-dcl and
pravusjif
AnsisMalins
approved these changes
Jan 28, 2025
sandrade-dcl
requested review from
fcolarich
and removed request for
davidejensen and
pravusjif
anicalbano
reviewed
Jan 29, 2025
There was a problem hiding this comment.
✔️ Windows working as expected.
- The Start Navigation function is now working and we are able to switch
- With the filters it's also working and the icons are visible
- When jumping in to a selected location, it's also working as expected
- Went through all filters
- Used the All to show the list of places on the right corner, navigation option is also working.
Awaiting for Mac to approve the PR
29.01.2025_11.37.46_REC.mp4
Ludmilafantaniella
approved these changes
Jan 29, 2025
anicalbano
approved these changes
Jan 29, 2025
sandrade-dcl
deleted the
fix/wrong-navigation-when-we-click-on-map-markers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Fix #3108
When we selected any marker in the map (like an scene of interest) and tried to start the navigation to there, the navigation path was wrongly set, ignoring the pacel position of the marker and using the previous navigation.
How to test the changes?
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md