-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: block camera input #2999
fix: block camera input #2999
Conversation
Windows and Mac build successfull in Unity Cloud! You can find a link to the downloadable artifact below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🔴 I could only test on Windows as Mac failed. On Windows, I wasn't able to open the camera using the C shortcut, only by using the sidebar camera icon. All other shortcuts (B, P, I, U, etc.) worked fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix of previous issue was able to be seen on both platforms! ✅ All checks of this PR have passed on both platforms!
What does this PR change?
Stops the in-world-camera from spawning when using the chat or in the loading screen
How to test the changes?
Try the regular input blocks as well (Shortcuts, Movement, Camera, FreeCamera, Emotes and EmotesWheel). They should all behave the same
Our Code Review Standards
https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md