Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: block camera input #2999

Merged
merged 3 commits into from
Dec 13, 2024
Merged

fix: block camera input #2999

merged 3 commits into from
Dec 13, 2024

Conversation

dalkia
Copy link
Collaborator

@dalkia dalkia commented Dec 12, 2024

What does this PR change?

Stops the in-world-camera from spawning when using the chat or in the loading screen

How to test the changes?

  1. Launch the explorer with in world camera feature on
  2. Select the chat. Press C. The in world camera should not open
  3. Deselect the chat. Press C. The world camera should open
  4. Teleport anywhere. While loading screen is on, press C. The world camera should not open
  5. When arriving to destination, press C. The camera should open

Try the regular input blocks as well (Shortcuts, Movement, Camera, FreeCamera, Emotes and EmotesWheel). They should all behave the same

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

Copy link
Collaborator

@popuz popuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dalkia dalkia changed the title fix: block camera input in mac fix: block camera input Dec 12, 2024
@Ludmilafantaniella
Copy link

🔴 I could only test on Windows as Mac failed. On Windows, I wasn't able to open the camera using the C shortcut, only by using the sidebar camera icon. All other shortcuts (B, P, I, U, etc.) worked fine.

@DafGreco DafGreco self-requested a review December 13, 2024 14:56
Copy link

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix of previous issue was able to be seen on both platforms! ✅ All checks of this PR have passed on both platforms!

@dalkia dalkia merged commit 06b798a into dev Dec 13, 2024
5 checks passed
@dalkia dalkia deleted the fix/block-camera-input-in-chat branch December 13, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants