Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add /help command #2984

Merged
merged 3 commits into from
Dec 12, 2024
Merged

feat: Add /help command #2984

merged 3 commits into from
Dec 12, 2024

Conversation

mihakrajnc
Copy link
Contributor

What does this PR change?

Adds a /help command with a small refactor to remove deferred command creation and simplify the code.

fix:#2567

How to test the changes?

  1. Launch the explorer
  2. Try executing /help and other commands
  3. Check if command descriptions printed in /help are accurate.

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

@mihakrajnc mihakrajnc requested review from dalkia and popuz December 11, 2024 15:14
@github-actions github-actions bot requested a review from DafGreco December 11, 2024 15:14
Copy link
Collaborator

@m3taphysics m3taphysics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Collaborator

@dalkia dalkia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on your first PR! 👏 👏 👏

@aixaCode
Copy link
Collaborator

Would be great if we could add an intro message with info about /help command, like we did in the old client.
Screenshot 2024-12-11 173438
Overall, looks really solid 👏

Copy link

@Ludmilafantaniella Ludmilafantaniella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Feature verified on Windows and Mac. The /help command is working as expected displaying accurate data.

image

Smoke test was performed covering:

  • Existing command functionality
  • Teleport using chat and maps
  • Changing wereables
  • Social interactions --> Emote sync, wereables sync, chats, passport
  • Side Bar functionality
  • Profile info edit
  • Scenes/world visited: Doll House, Casa Roustan, world Pravus, World Olavra, Metadynelabs

@mihakrajnc mihakrajnc force-pushed the feat/help-chat-command branch from f0f9c2a to 03fc8fa Compare December 12, 2024 14:43
@Ludmilafantaniella
Copy link

/help command successfully added at the start of the game.

image

@mihakrajnc mihakrajnc merged commit 3b35332 into dev Dec 12, 2024
5 checks passed
@mihakrajnc mihakrajnc deleted the feat/help-chat-command branch December 12, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants