Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: screencapture HUD for camera reel #2914

Merged
merged 87 commits into from
Dec 3, 2024
Merged

Feat: screencapture HUD for camera reel #2914

merged 87 commits into from
Dec 3, 2024

Conversation

popuz
Copy link
Collaborator

@popuz popuz commented Nov 28, 2024 •
edited
Loading

What does this PR change?

It brings Screencapture HUD with respective buttons and visual effects. Also several polishing things were maid.
It includes:

  • sidebar button for entering camera mode
  • hiding all UI when entering camera mode
  • blocking and resetting raycasts when in camera mode
  • screencapture VFX when capturing screenshot
  • fixed cursor lock/unlock that is similar to normal cursor behaviour

How to test the changes?

  1. Launch the explorer and explore screencapture camera mode
  2. Open it via sidebar button and verify it behaves correctly
  3. Open-close via C button
  4. Exploratory testing of opening/closing via different modes and opening other tabs
  5. Capture screenshot via button and via shortcut - verify VFX and splash going down.
  6. Shortcuts menu open/close

Verify that without proper args it is not presented (sidebar and shortcuts doesn't work)

Note: known issues for further polishing

  • not all shortcuts are blocked when in camera mode
  • audio effects are behaving not always properly
  • vfx overlaps camera reel button at the end

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

popuz added 30 commits October 30, 2024 21:10
@popuz
screen capturing is working fine
5d40013
@popuz
add UI and CameraObject
2478b13
@popuz
Merge branch 'refs/heads/dev' into feat/camera-reel/screen-recorder
ce2a3b1
@popuz
wip on camera input controls
4392e99
@popuz
Merge branch 'refs/heads/dev' into feat/camera-reel/screen-recorder
66926b1 
# Conflicts:
#	Explorer/Assets/DCL/InWorldCamera.meta
@popuz
add plugin initialization for the feature
ddf29af
@popuz
wip on camera controls and prototype screenshooting
3c79603
@popuz
add most of the screenshot metadata on capture (except Visible Players)
9dc3a96
@popuz
wip on collecting screenshot metadata VisiblePersons
25f6f96
@popuz
corrected metadata as it was in old client
2fb5666
@popuz
collecting users metadata works
4ae3e96
@popuz
with self profile in metadata (on second shot)
884d38d
@popuz
wip on extracting Camera Movement behaviour
88ce21d
@popuz
fixed switching
f71d222
@popuz
some refactoring
fbaa66b
@popuz
wip on logic separation
937d262
@popuz
cleanup and refactoring with working screenshot
eeb2d56
@popuz
main refactoring and clean up
bcd2938
@popuz
Merge branch 'refs/heads/dev' into feat/camera-reel/screen-recorder-a…
31c6951 
…nd-metadata

# Conflicts:
#	Explorer/Assets/AddressableAssetsData/AssetGroups/Essentials.asset
#	Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset
#	Explorer/Assets/Scripts/Global/Dynamic/Bootstraper.cs
#	Explorer/Assets/Scripts/Global/Dynamic/DynamicWorldContainer.cs
@popuz
reverted un-needed changes
e7ca190
@popuz
forgotten unneeded code
18fed95
@popuz
small allocation improvement
77b885b
@popuz
scaled frustrum planes to improve precision of visible people
893ff68
@popuz
brought back camera with free movement + small extraction of movement…
d0e3870 
… logic
@popuz
wip on extracting cinemachine logic
b5b6486
@popuz
wip on POV
7f0e758
@popuz
extracting movement to a separate system
cd34a8e
@popuz
wip on translation
0bce7ec
@popuz
add panning
3535e91
@popuz
add smooth rotation for inWorldCamera
1dcba99
QThund
QThund requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@QThund QThund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, most of the comments are clarifications or minor things.

@popuz popuz requested a review from QThund November 29, 2024 18:06
davidejensen
davidejensen approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@davidejensen davidejensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with some minor comments

Explorer/Assets/DCL/InWorldCamera/InWorldCamera/Playground/ScreenRecorderTester.cs Show resolved Hide resolved
Explorer/Assets/DCL/InWorldCamera/InWorldCamera/UI/Animations/Active.anim Show resolved Hide resolved
Explorer/Assets/DCL/InWorldCamera/InWorldCamera/UI/InWorldCameraController.cs Outdated Show resolved Hide resolved
Explorer/Assets/DCL/InWorldCamera/InWorldCamera/UI/InWorldCameraController.cs Show resolved Hide resolved
Explorer/Assets/DCL/InWorldCamera/InWorldCamera/UI/InWorldCameraController.cs Show resolved Hide resolved
Explorer/Assets/DCL/InWorldCamera/InWorldCamera/UI/InWorldCameraView.cs Outdated Show resolved Hide resolved
Explorer/Assets/DCL/InWorldCamera/InWorldCamera/UI/ScreencaptureShortcutsController.cs Outdated Show resolved Hide resolved
DafGreco
DafGreco approved these changes Dec 2, 2024
View reviewed changes
Copy link

@DafGreco DafGreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation added successfully on both platforms! ✅

All commands have been checked on both platforms and issues are going to be collected on a sheet.

@popuz popuz merged commit f08861a into dev Dec 3, 2024
5 checks passed
@popuz popuz deleted the feat/camera-reel/screencapture-hud branch December 3, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DafGreco DafGreco DafGreco approved these changes

@QThund QThund QThund approved these changes

@davidejensen davidejensen davidejensen approved these changes

@mikhail-dcl mikhail-dcl Awaiting requested review from mikhail-dcl

Assignees

@popuz popuz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@popuz @davidejensen @QThund @DafGreco @RominaMarchetti