feat: Missing props on social service events (#331)

* feat: Missing props on social service events * chore: Refresh API
decentraland · Feb 5, 2025 · 646385f · 646385f
1 parent b797259
commit 646385f
Show file tree

Hide file tree

Showing 3 changed files with 54 additions and 15 deletions.
diff --git a/report/schemas.api.md b/report/schemas.api.md
@@ -1324,13 +1324,18 @@ export type FriendshipAcceptedEvent = BaseEvent & {
     type: Events.Type.SOCIAL_SERVICE;
     subType: Events.SubType.SocialService.FRIENDSHIP_ACCEPTED;
     metadata: {
+        requestId: string;
         sender: {
             address: string;
             name: string;
             profileImageUrl: string;
+            hasClaimedName: boolean;
         };
         receiver: {
             address: string;
+            name: string;
+            profileImageUrl: string;
+            hasClaimedName: boolean;
         };
     };
 };
@@ -1351,13 +1356,18 @@ export type FriendshipRequestEvent = BaseEvent & {
     type: Events.Type.SOCIAL_SERVICE;
     subType: Events.SubType.SocialService.FRIENDSHIP_REQUEST;
     metadata: {
+        requestId: string;
         sender: {
             address: string;
             name: string;
             profileImageUrl: string;
+            hasClaimedName: boolean;
         };
         receiver: {
             address: string;
+            name: string;
+            profileImageUrl: string;
+            hasClaimedName: boolean;
         };
         message?: string;
     };

diff --git a/src/platform/events/services.ts b/src/platform/events/services.ts
@@ -120,18 +120,22 @@ export type FriendshipRequestEvent = BaseEvent & {
   type: Events.Type.SOCIAL_SERVICE
   subType: Events.SubType.SocialService.FRIENDSHIP_REQUEST
   metadata: {
+    requestId: string
     sender: {
       address: string
       name: string
       profileImageUrl: string
+      hasClaimedName: boolean
     }
     receiver: {
       address: string
+      name: string
+      profileImageUrl: string
+      hasClaimedName: boolean
     }
     message?: string
   }
 }
-
 export namespace FriendshipRequestEvent {
   export const schema: JSONSchema<FriendshipRequestEvent> = {
     type: 'object',
@@ -143,25 +147,30 @@ export namespace FriendshipRequestEvent {
       metadata: {
         type: 'object',
         properties: {
+          requestId: { type: 'string' },
           sender: {
             type: 'object',
             properties: {
               address: { type: 'string' },
               name: { type: 'string' },
-              profileImageUrl: { type: 'string' }
+              profileImageUrl: { type: 'string' },
+              hasClaimedName: { type: 'boolean' }
             },
-            required: ['address', 'name', 'profileImageUrl']
+            required: ['address', 'name', 'profileImageUrl', 'hasClaimedName']
           },
           receiver: {
             type: 'object',
             properties: {
-              address: { type: 'string' }
+              address: { type: 'string' },
+              name: { type: 'string' },
+              profileImageUrl: { type: 'string' },
+              hasClaimedName: { type: 'boolean' }
             },
-            required: ['address']
+            required: ['address', 'name', 'profileImageUrl', 'hasClaimedName']
           },
           message: { type: 'string', nullable: true }
         },
-        required: ['sender']
+        required: ['requestId', 'sender', 'receiver']
       }
     },
     required: ['type', 'subType', 'key', 'timestamp', 'metadata'],
@@ -175,13 +184,18 @@ export type FriendshipAcceptedEvent = BaseEvent & {
   type: Events.Type.SOCIAL_SERVICE
   subType: Events.SubType.SocialService.FRIENDSHIP_ACCEPTED
   metadata: {
+    requestId: string
     sender: {
       address: string
       name: string
       profileImageUrl: string
+      hasClaimedName: boolean
     }
     receiver: {
       address: string
+      name: string
+      profileImageUrl: string
+      hasClaimedName: boolean
     }
   }
 }
@@ -197,24 +211,29 @@ export namespace FriendshipAcceptedEvent {
       metadata: {
         type: 'object',
         properties: {
+          requestId: { type: 'string' },
           sender: {
             type: 'object',
             properties: {
               address: { type: 'string' },
               name: { type: 'string' },
-              profileImageUrl: { type: 'string' }
+              profileImageUrl: { type: 'string' },
+              hasClaimedName: { type: 'boolean' }
             },
-            required: ['address', 'name', 'profileImageUrl']
+            required: ['address', 'name', 'profileImageUrl', 'hasClaimedName']
           },
           receiver: {
             type: 'object',
             properties: {
-              address: { type: 'string' }
+              address: { type: 'string' },
+              name: { type: 'string' },
+              profileImageUrl: { type: 'string' },
+              hasClaimedName: { type: 'boolean' }
             },
-            required: ['address']
+            required: ['address', 'name', 'profileImageUrl', 'hasClaimedName']
           }
         },
-        required: ['sender']
+        required: ['requestId', 'sender', 'receiver']
       }
     },
     required: ['type', 'subType', 'key', 'timestamp', 'metadata'],

diff --git a/test/platform/events/services.spec.ts b/test/platform/events/services.spec.ts
@@ -9,13 +9,18 @@ describe('Services tests', () => {
       key: 'key',
       timestamp: 1,
       metadata: {
+        requestId: 'requestId',
         sender: {
           address: '0x123sender',
           name: 'name',
-          profileImageUrl: 'https://profileImageUrl.dcl.org'
+          profileImageUrl: 'https://profileImageUrl.dcl.org',
+          hasClaimedName: true
         },
         receiver: {
-          address: '0x456receiver'
+          address: '0x456receiver',
+          name: 'name',
+          profileImageUrl: 'https://profileImageUrl.dcl.org',
+          hasClaimedName: true
         },
         message: 'message'
       }
@@ -33,13 +38,18 @@ describe('Services tests', () => {
       key: 'key',
       timestamp: 1,
       metadata: {
+        requestId: 'requestId',
         sender: {
           address: '0x123sender',
           name: 'name',
-          profileImageUrl: 'https://profileImageUrl.dcl.org'
+          profileImageUrl: 'https://profileImageUrl.dcl.org',
+          hasClaimedName: true
         },
         receiver: {
-          address: '0x456receiver'
+          address: '0x456receiver',
+          name: 'name',
+          profileImageUrl: 'https://profileImageUrl.dcl.org',
+          hasClaimedName: true
         }
       }
     }