Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UITransform pointer filter #799

Closed
wants to merge 3 commits into from

Conversation

pravusjif
Copy link
Member

No description provided.

@pravusjif pravusjif self-assigned this Oct 23, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 23, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c1f0e06
Status: ✅  Deploy successful!
Preview URL: https://389de2f3.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-ui-transform-pointer-fi.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/ui-transform-pointer-filter/dcl-sdk-7.3.24-6619087672.commit-4e548b2.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/ui-transform-pointer-filter/dcl-sdk-commands-7.3.24-6619087672.commit-4e548b2.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/ui-transform-pointer-filter/@dcl/inspector/dcl-inspector-7.3.24-6619087672.commit-4e548b2.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/ui-transform-pointer-filter-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/ui-transform-pointer-filter

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1533637) 70.91% compared to head (c1f0e06) 79.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
+ Coverage   70.91%   79.24%   +8.32%     
==========================================
  Files         394      138     -256     
  Lines       13069     4534    -8535     
  Branches     1753      790     -963     
==========================================
- Hits         9268     3593    -5675     
+ Misses       3590      867    -2723     
+ Partials      211       74     -137     

see 256 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pravusjif
Copy link
Member Author

Closing in favor of #798

@pravusjif pravusjif closed this Oct 24, 2023
@pravusjif pravusjif deleted the feat/ui-transform-pointer-filter branch October 24, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant