add: GLTF screenshots #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
35f2e2e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://06396271.js-sdk-toolchain.pages.dev |
| Branch Preview URL: | https://add-gltf-ss.js-sdk-toolchain.pages.dev |
nicoecheza
force-pushed
the
add/gltf-ss
branch
from
aee2af2 to
dba05b0
Compare
Test this pull request
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #794 +/- ##
==========================================
- Coverage 70.92% 70.48% -0.45%
==========================================
Files 394 399 +5
Lines 13074 13199 +125
Branches 1754 1758 +4
==========================================
+ Hits 9273 9303 +30
- Misses 3590 3682 +92
- Partials 211 214 +3
☔ View full report in Codecov by Sentry. |
nicoecheza
force-pushed
the
add/gltf-ss
branch
2 times, most recently
from
cb6286d to
4b0c7db
Compare
|
Importing models external files does work fine 👍 but importing them from the Asset Packs tab does not create a thumbnail.. seems inconsistent, and considering that the models do have a thumbnail in one tab it shouldn't be a huge effort to copy them to the Local Assets, right? |
nicoecheza
force-pushed
the
add/gltf-ss
branch
2 times, most recently
from
cb4f4c9 to
64429a5
Compare
cazala
reviewed
Oct 23, 2023
packages/@dcl/inspector/src/lib/data-layer/client/feeded-local-fs.ts
Outdated
Show resolved
Hide resolved
nicoecheza
force-pushed
the
add/gltf-ss
branch
14 times, most recently
from
a23a392 to
91bdea3
Compare
cazala
reviewed
Oct 23, 2023
nicoecheza
force-pushed
the
add/gltf-ss
branch
4 times, most recently
from
966ce05 to
627305c
Compare
nicoecheza
force-pushed
the
add/gltf-ss
branch
from
627305c to
35f2e2e
Compare
cazala
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes decentraland/sdk#718
🤖 Generated by Copilot at aee2af2
This pull request adds the feature of displaying and saving thumbnails for the asset files in the inspector. It introduces a new
AssetPreviewcomponent that renders a 3D model or an image file and allows taking a screenshot of it. It also adds new RPC methods and messages to the data layer to handle the thumbnails. It modifies theImportAssetandProjectAssetExplorercomponents to use the new functionality and updates the CSS and types files accordingly. It fixes some issues with the GLTF validation and loading and improves the error handling and the image encoding in the data layer. It also adds a mock thumbnail file to the feeded-local-fs and an empty change to the input.ts file.