Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UITransform pointer filter property #792

Merged
merged 18 commits into from
Oct 23, 2023

Conversation

pravusjif
Copy link
Member

@pravusjif pravusjif commented Oct 17, 2023

  • Updated protocol
  • Exposed new PointerFilter property in UiTransform

Related PRs:

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 17, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 377e6a0
Status: ✅  Deploy successful!
Preview URL: https://a87f0faf.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-ui-pointer-blocker-prop.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/ui-pointer-blocker-property-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/ui-pointer-blocker-property

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6487fd5) 70.91% compared to head (377e6a0) 70.92%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #792      +/-   ##
==========================================
+ Coverage   70.91%   70.92%   +0.01%     
==========================================
  Files         394      394              
  Lines       13069    13074       +5     
  Branches     1753     1754       +1     
==========================================
+ Hits         9268     9273       +5     
  Misses       3590     3590              
  Partials      211      211              
Files Coverage Δ
...ages/@dcl/react-ecs/src/components/Label/index.tsx 100.00% <ø> (ø)
...@dcl/react-ecs/src/components/uiTransform/index.ts 100.00% <ø> (ø)
...@dcl/react-ecs/src/components/uiTransform/utils.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pravusjif
Copy link
Member Author

Final protocol package will be used after Protocol PR is merged and before merging this PR.

@pravusjif pravusjif requested a review from gonpombo8 October 18, 2023 17:22
@pravusjif pravusjif marked this pull request as ready for review October 18, 2023 17:22
@pravusjif pravusjif requested a review from gonpombo8 October 20, 2023 12:41
@pravusjif pravusjif changed the title feat: UI pointer blocker property feat: UITransform pointer filter property Oct 23, 2023
@pravusjif pravusjif merged commit 887e14c into main Oct 23, 2023
8 of 10 checks passed
@pravusjif pravusjif deleted the feat/ui-pointer-blocker-property branch October 23, 2023 12:49
pravusjif added a commit that referenced this pull request Oct 23, 2023
@pravusjif pravusjif restored the feat/ui-pointer-blocker-property branch October 23, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants