Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: document new enable/disable outline feature #480

Merged
merged 4 commits into from
Jan 21, 2025

Conversation

juanmahidalgo
Copy link
Contributor

@juanmahidalgo juanmahidalgo commented Jan 15, 2025

image

Copy link

cloudflare-workers-and-pages bot commented Jan 15, 2025

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: 427b393
Status: ✅  Deploy successful!
Preview URL: https://a0b31e76.new-docs-6m4.pages.dev
Branch Preview URL: https://feat-document-outline.new-docs-6m4.pages.dev

View logs

@@ -128,6 +128,18 @@ Tags are simply descriptive words that users can use when searching or filtering

When this property is enabled, it will allow owners of your item to include it in VRM Avatar Exports so they can show it off outside of Decentraland.

# **Outline**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the title size h2

we only use h1 on the automatically generated page header

- Shows visual artifacts when the outline effect is applied

Most wearables work fine with the default setting (enabled). Only disable this if you notice outline-related visual issues with your wearable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also add a mention of where users find this outline toggle?
Or a screenshot that shows it

Otherwise if a user reads this without the Builder window already open, they don't know where they can configure this setting.

@juanmahidalgo juanmahidalgo merged commit 400a9ce into main Jan 21, 2025
2 checks passed
@juanmahidalgo juanmahidalgo deleted the feat/document-outline branch January 21, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants