Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Organizational Chart to DAO Documentation #306

Merged
merged 18 commits into from
Jan 12, 2024

Conversation

tweebitdao
Copy link
Contributor

@ginocingolani
Copy link
Member

@lordlikedao I'd recommend updating the How the DAO Works article with committees and org charts. Also, it would be better if the images were stored in the images folder on this repo https://github.com/decentraland/documentation/blob/main/images

@tweebitdao
Copy link
Contributor Author

@nearnshaw Could you please review this PR ?

@nearnshaw
Copy link
Member

@lordlikedao approved!

@tweebitdao
Copy link
Contributor Author

@nearnshaw Hey, thanks with a quick respond and approve.

As far as I know, approved doesn’t mean closed. This pull request is still opened and it means that changes have not been merged into the branch yet, right?

Cause I can’t see the suggested folder with photos in the “images” folder in the main brunch. And the last update there was three days ago.

Could you please let me know what else is needed to close the pull request, so these changes appear in the Decentraland documentation repository?

@nearnshaw
Copy link
Member

@lordlikedao right, approved doesn't mean the changes are published. For that, you need to press the "Squash and merge" green button that appears in this screen. After that, the build process can last a few minutes, and then the site should be updated.

@tweebitdao
Copy link
Contributor Author

@nearnshaw I don't have access to press the "Squash and merge". I have only close pull request button. Could you please do it ?

@nearnshaw nearnshaw merged commit e34f34c into decentraland:main Jan 12, 2024
1 check passed
@nearnshaw
Copy link
Member

@lordlikedao done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants