Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relative positions #6

Merged
merged 2 commits into from
Dec 2, 2024
Merged

relative positions #6

merged 2 commits into from
Dec 2, 2024

Conversation

nearnshaw
Copy link
Contributor

No description provided.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall but I'd like you to double check some comments, I might be wrong and no action is needed, let me know and I'll change the approval 😄

README.md Show resolved Hide resolved
src/ui-entities/prompts/Prompt/components/Icon/index.tsx Outdated Show resolved Hide resolved
// bottom: 0.2,
// left: 0.2,
// right: 0.2
// },

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can delete commented out code? As well as in line 243

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, for sure
I was just leaving this in for now while I tried things semi randomly without knowing if I have to uncomment them :p

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nearnshaw nearnshaw merged commit 1b97bae into main Dec 2, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants