Make footer max width 100vw to fix lighthouse test error #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy request for gatsby-starter-netlify-cms-ci pending review. Review with commit bf1b2a1 https://app.netlify.com/sites/gatsby-starter-netlify-cms-ci/deploys |
btahir
changed the title
|
Thanks @btahir ! |
alexjain27
added a commit
to alexjain27/gatsby-starter-netlify-cms-1
that referenced
this pull request
Oct 2, 2020
* fix(deps): update dependency netlify-cms-app to v2.11.18 * fix: use getAsset in preview templates (decaporg#496) * fix(deps): update dependency netlify-cms-app to v2.11.19 * Fix readme typo * chore(deps): lock file maintenance * chore(deps): lock file maintenance * fix(deps): update dependency netlify-cms-app to v2.11.20 * fix(deps): update dependency netlify-cms-app to v2.11.21 * fix(deps): update dependency netlify-cms-app to v2.11.22 * fix(deps): update dependency netlify-cms-app to v2.11.23 * fix(deps): update dependency gatsby-remark-relative-images to ^0.3.0 * chore(deps): lock file maintenance * fix(deps): update dependency netlify-cms-app to v2.11.24 * fix(deps): update dependency netlify-cms-app to v2.11.25 * fix(deps): update dependency netlify-cms-app to v2.11.26 * fix(deps): update gatsby monorepo * chore(deps): lock file maintenance * fix(deps): update dependency netlify-cms-app to v2.11.27 * fix(deps): update gatsby monorepo * fix(deps): update gatsby monorepo * fix(deps): update dependency netlify-cms-app to v2.11.32 * fix(deps): update react monorepo to v16.13.1 * fix(deps): update dependency bulma to v0.8.1 * fix(deps): update dependency netlify-cms-app to v2.12.0 * fix(deps): update dependency netlify-cms-app to v2.12.1 * fix(deps): update dependency netlify-cms-app to v2.12.2 * fix(deps): update dependency netlify-cms-app to v2.12.3 * fix(deps): update dependency uuid to v7 (decaporg#515) Co-authored-by: Renovate Bot <[email protected]> * fix(deps): update dependency netlify-cms-app to v2.12.4 * fix(deps): update dependency netlify-cms-app to v2.12.5 * fix(deps): update dependency netlify-cms-app to v2.12.6 * fix(deps): update dependency netlify-cms-app to v2.12.7 * fix(deps): update dependency bulma to v0.8.2 * fix(deps): update dependency netlify-cms-app to v2.12.8 * fix(deps): update dependency netlify-cms-app to v2.12.9 * fix(deps): update dependency netlify-cms-app to v2.12.10 * fix(deps): update dependency netlify-cms-app to v2.12.11 * Fix _headers syntax (decaporg#546) TOML content in a _headers file is not allowed and is ignore by production. * ci(Netlify): update yarn and node versions to fix build failure (decaporg#552) * ci: update yarn & node versions * chore(deps): update all dependencies * chore(deps): update lock file * fix(deps): update gatsby monorepo * fix(deps): update gatsby monorepo * chore(deps): lock file maintenance * chore(deps): lock file maintenance * chore(deps): lock file maintenance * fix(deps): update dependency netlify-cms-app to v2.12.12 * fix(deps): update dependency node-sass to v4.14.1 * fix(deps): update gatsby monorepo * fix(deps): update gatsby monorepo * fix(deps): update dependency netlify-cms-app to v2.12.13 * Make footer max width 100vw to fix lighthouse test error (decaporg#574) * restrict footer width to 100vw * make it camel case * fix(deps): update gatsby monorepo * fix(deps): update dependency gatsby to v2.22.15 * fix(deps): update dependency netlify-cms-app to v2.12.14 * chore(deps): [security] bump websocket-extensions from 0.1.3 to 0.1.4 Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. **This update includes a security fix.** - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](faye/websocket-extensions-node@0.1.3...0.1.4) Signed-off-by: dependabot-preview[bot] <[email protected]> * fix(deps): update dependency bulma to ^0.9.0 * chore(deps): lock file maintenance * chore(deps): lock file maintenance * fix(deps): update dependency react-helmet to v6.1.0 * Update link to JavaScript Lambda functions docs (decaporg#585) * fix(deps): update dependency netlify-cms-app to v2.12.15 * fix(deps): update gatsby monorepo * chore(deps): lock file maintenance * fix(deps): update dependency gatsby to v2.23.7 * chore(deps): lock file maintenance * fix(deps): update gatsby monorepo * chore(deps): lock file maintenance * fix(deps): update dependency netlify-cms-app to v2.12.16 * fix(deps): update gatsby monorepo * chore(deps): lock file maintenance * Typo fix in readme (decaporg#596) Thanks! * chore(deps): lock file maintenance * fix(deps): update dependency netlify-cms-app to v2.12.17 * fix(deps): update dependency netlify-cms-app to v2.12.18 * chore(deps): lock file maintenance * chore(deps): lock file maintenance * fix(deps): update gatsby monorepo * fix(deps): update dependency netlify-cms-media-library-cloudinary to v1.3.5 * fix(deps): update dependency netlify-cms-app to v2.12.19 * fix(deps): update dependency netlify-cms-media-library-uploadcare to v0.5.6 * fix(deps): update gatsby monorepo * fix(deps): update gatsby monorepo * fix(deps): update dependency netlify-cms-media-library-cloudinary to v1.3.6 * fix(deps): update dependency netlify-cms-media-library-uploadcare to v0.5.7 * chore(deps): update dependency prettier to v2.1.1 * fix(deps): update dependency netlify-cms-media-library-cloudinary to v1.3.7 * fix(deps): update dependency netlify-cms-media-library-uploadcare to v0.5.8 * fix(deps): update dependency netlify-cms-media-library-cloudinary to v1.3.8 * fix(deps): update dependency netlify-cms-media-library-uploadcare to v0.5.9 * chore(deps): update dependency prettier to v2.1.2 Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Erez Rokah <[email protected]> Co-authored-by: Kevin Borrill <[email protected]> Co-authored-by: Zoli Veres <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Raees Iqbal <[email protected]> Co-authored-by: Bilal <[email protected]> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Adriana Babakanian <[email protected]> Co-authored-by: Charlie Bevis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to this issue
Lighthouse was giving an error on the Mobile viewport:
The viewport size is 424px, whereas the window size is 412px. This can be seen on mobile phone size screens when you swipe left the page moves.
This PR restricts the width of the footer to 100vw which fixes this.
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?