Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine #28

Merged
merged 5 commits into from
Nov 7, 2019
Merged

Combine #28

merged 5 commits into from
Nov 7, 2019

Conversation

roman-hrybinchuk
Copy link
Collaborator

@roman-hrybinchuk roman-hrybinchuk commented Nov 7, 2019

Supports #6

implementation for combine(), changed code style, files put to different folder, test for new token structure.

@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #28 into develop will increase coverage by 0.04%.
The diff coverage is 98.23%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #28      +/-   ##
===========================================
+ Coverage    98.01%   98.06%   +0.04%     
===========================================
  Files            9       10       +1     
  Lines          352      361       +9     
===========================================
+ Hits           345      354       +9     
  Misses           7        7
Impacted Files Coverage Δ
data_highlight/support/char_array.py 100% <ø> (ø) ⬆️
data_highlight/support/line.py 100% <100%> (ø) ⬆️
test/test_Colors.py 96.77% <100%> (ø) ⬆️
test/test_Recording.py 98.18% <100%> (ø) ⬆️
data_highlight/highlighter.py 100% <100%> (+1.28%) ⬆️
test/test_Splitting.py 98.38% <100%> (ø) ⬆️
data_highlight/support/token.py 100% <100%> (ø) ⬆️
data_highlight/support/color_picker.py 100% <100%> (ø) ⬆️
test/test_line_count.py 92.85% <87.5%> (ø) ⬆️
data_highlight/highlighter_functionality/export.py 96.96% <96.96%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5adf5a...e8ce330. Read the comment docs.

@IanMayo
Copy link
Member

IanMayo commented Nov 7, 2019

Hello @Romucmad - that's the first part done :-)

I'll merge it, and you can start work on implementing, testing combine() in another branch/PR

@IanMayo IanMayo merged commit 4cdc5cd into develop Nov 7, 2019
@IanMayo IanMayo deleted the combine branch November 7, 2019 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants