Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use check_mode instead of always_run #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fabianfreyer
Copy link

always_run is being deprecated in ansible 2.4

always_run is being deprecated in ansible 2.4
Copy link
Member

@ypid ypid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is incomplete as the check_mode was introduced in 2.2 and does not work with Ansible 2.1 which is the current minimum version for this role (ref: meta/main.yml).
Also note that the Ansible min version is also documented in:

(ansible-update-min-version could be used or a simple find | xargs sed combo.)

@ganto So far, I try to still support 2.1 for my roles but you can update the role to 2.2 min Ansible version if you like. I don’t see a problem with that.

@ganto
Copy link
Member

ganto commented Nov 15, 2016

@fabianfreyer Thanks for the PR. But currently the role defines version 2.1.1 as minimal supported Ansible version. Only to support a new variable name for the same feature which already exists now, I don't intend to raise that. That said, there is no hurry to move to check_mode yet.

Did you try to run the role with --check without issues but the dependency warnings? I can't remember if I even tried that yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants