Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Broken Tilde and Grave (Backtick/Backquote) (regression bugfix) #1711

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix Broken Tilde and Grave (Backtick/Backquote) (regression bugfix) #1711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed37361
Fix Broken Tilde and Grave (Backtick/Backquote)
dgentry Jul 6, 2022
645a0c9
Remove no-longer-possible Mojave build from azure
dgentry Jul 6, 2022
ee11f5c
Remove Windows-breaking change that fixes Mac-warnings
dgentry Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,10 +91,11 @@ jobs:
imageName: "macOS-10.15"
B_BUILD_TYPE: Release
BARRIER_VERSION_STAGE: Release
mojave-Release:
imageName: "macOS-10.14"
B_BUILD_TYPE: Release
BARRIER_VERSION_STAGE: Release
# Azure has removed the macOS-10.14 image, so this will never work
# mojave-Release:
# imageName: "macOS-10.14"
# B_BUILD_TYPE: Release
# BARRIER_VERSION_STAGE: Release
pool:
vmImage: $(imageName)
variables:
Expand Down
3 changes: 3 additions & 0 deletions doc/newsfragments/1541-fix-broken-tilde-and-grave
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix the regression introduced in #1214 that caused tilde (~) and grave
(`) to stop being sendable from at least a MacOS Barrier Server (and
probably others). Fixes Issues #1541 and #1407
2 changes: 0 additions & 2 deletions src/lib/platform/OSXKeyState.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,6 @@ static const KeyEntry s_controlKeys[] = {
{ kKeyEisuToggle, kVK_JIS_Eisu },
{ kKeyKana, kVK_JIS_Kana },
{ kKeyMuhenkan, s_int5VK },
{ kKeyHenkan, s_int4VK },
{ kKeyZenkaku, kVK_ANSI_Grave }
};


Expand Down