Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not set content text alpha when sets the title #85

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Do not set content text alpha when sets the title #85

wants to merge 2 commits into from

Conversation

sandrocsimas
Copy link

private void setTitleText(CharSequence contentText) {
    if(this.mTitleTextView != null && !contentText.equals("")) {
        // THIS LINE SHOULD NOT EXIST
        this.mContentTextView.setAlpha(0.5F);
        this.mTitleTextView.setText(contentText);
    }
}

Why this code sets the mContextTextView alpha to 0.5?

MaterialShowcaseView.Builder builder = new MaterialShowcaseView.Builder(activity);
builder.setTarget(view);
builder.setTitleText(titleResource);
builder.setContentText(detailResource);
builder.setContentTextColor(android.R.color.white);
builder.setDismissText(R.string.showcase_got_it);
builder.setDismissOnTouch(false);
builder.setDelay(Constants.SHOWCASE_SHOW_DELAY);
builder.setMaskColour(ContextCompat.getColor(activity, R.color.primary_showcase));
builder.singleUse(singleUseId);

Setting the content text color does not solve the problem...

@sandrocsimas
Copy link
Author

Sorry, i push two features, can you fix that?

Do not set content text alpha
Adding methods to change the title and content size

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant