Use newer tools/SDK + work w/ API >= 8 (ie, Froyo+) #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* minSDK: 8 / targetSDK: 23 * No animations before API 11 * use appcompat/support + minor tweaks to support Froyo+ * updated gradle plugin, build tools, etc. The sample app works on Froyo emulator + tested on actual gingerbread device. Could use verification w/other older devices to make sure nothing broke but seems to work okay.
| @@ -47,7 +47,7 @@ int getSequenceStatus() { | |||
|
|
|||
| void setSequenceStatus(int status) { | |||
| SharedPreferences internal = context.getSharedPreferences(PREFS_NAME, Context.MODE_PRIVATE); | |||
| internal.edit().putInt(STATUS + showcaseID, status).apply(); | |||
| internal.edit().putInt(STATUS + showcaseID, status).commit(); | |||
There was a problem hiding this comment.
I should mention that these were changed because .apply() didn't show up until API 9.
|
@deano2390 we are waiting :) |
|
@ntoskrnl Sorry i've been so busy these last few weeks! I will review and merge as soon as I get chance. Thanks for your patience, your contributions to the project are much appreciated :) |
|
Hi @deano2390 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys-- Just found this library a few hours ago and figured I could backport it to work w/Froyo. Gave it a shot! Images below.
Notes:
The sample app works on Froyo emulator + tested on actual gingerbread device. Could use
verification w/other older devices to make sure nothing broke but seems to work okay.
FROYO (from emulator)
GINGERBREAD (actual device)
