-
Notifications
You must be signed in to change notification settings - Fork 602
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Dean Malmgren
committed
Oct 10, 2015
1 parent
a54c22d
commit d1ce0cb
Showing
2 changed files
with
4 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
from .parsers import process | ||
|
||
VERSION = "1.3.0" | ||
VERSION = "1.4.0" |
d1ce0cb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Dean,
Thanks for this excellent package, it certainly looks like it's going to make my life easier :-)
For your information, I have had some issues due to python 3.5.0. I ran your textract-master through python's 2to3 tool, and changed pdfminer into pdfminer3k in the dependencies. I easy_installed with python 3.5.0 and it works as a charm on docx and pdf files (only tested those). I would be glad to contribute this, but I am a total nitwit when it comes to github. If this is helpful to you, just point me in the right direction on how I can help out.
Thanks again for writing this.
Bernie.
d1ce0cb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bcaessens,
Thanks for the note. I'd love to make textract python3 compatible and I'd really appreciate the contribution. This came up in #91 but the authors of that pull request did not create the package in a conventional python fashion and we abandoned that line of work.
If you've started along the path to python3 integration, I'd encourage you to start a pull request and we can use the pull request as a means to figure out a solution to things.
To determine if your solution works for other document types beyond docx and pdfs, I'd encourage you to extend the test suite in
.travis.yml
to also run the tests on python 3.5 by adding a line here. You should also be able to run the entire test suite locally by running the./tests/run.py
script.I look forward to the pull request and getting this incorporated into textract. Very exciting!
Cheers,
Dean