Add support for Python 3 via six, some rewriting #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Looks like the bad checksum issue will cause the CI to fail, so might need to see about verifying that a bad checksum is indeed correct,first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to give
flosupport forpy3k. I've largely usedsixto replace a few calls, and rewritten some arguments to be more pythonic.In tests, the output produced by
run_functional_tests.shis essentially identical for this new version and the original; only timestamped directories seemed to differ. (I usedFabric3for the python 3 runs). That said, I should point out that ALL of my versions - including the pip install - returned identical bad checksums at the two instances where checksums are calculated.