Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new UI once more #318

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

A new UI once more #318

wants to merge 40 commits into from

Conversation

davidpkj
Copy link

@davidpkj davidpkj commented Sep 5, 2024

Hi all, so this is yet another attempt to get a new UI for this project. This PR is largely based on doebi's work at #265 with some additions like:

  • Fixed issues like
    • Multiple HTML5 Backends
    • Upload failing with uppercase extensions
  • An updated home page with useful tips
  • Unified most style rules to SCSS files
  • Unified main UI logic under JSX files
  • A beautiful brown color scheme

Let me know what you think! (I heard three time's the charm 😉)

@ddvk
Copy link
Owner

ddvk commented Sep 26, 2024

Hey, thanks a lot for putting the effort in, it looks very nice.

there are a couple of minor issues:

  • uploading a file doesn't refresh the tree (I know the current implementation is also hacky and I never got to implementing live updates)

  • the UI doesn't use the whole browser window on a large display (my main gripe)
    image
    vs
    image

  • when a document has been selected, there is no way to upload another document (should first select folder)

@davidpkj
Copy link
Author

Hey, glad you like it! I have now fixed the first two issues, but would like to leave the third behavior as is. My reasoning being:

  • It is clearer/more explicit which folder the file will be uploaded to
  • It's not difficult from a UX perspective to select a folder beforehand (to either use the path above the file preview or the file tree to the left)
  • The upload box would get in the way on mobile devices with small screens. This leaves more space for the preview while having to scroll less.

Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants