-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to using version number instead of /etc/version #128
Conversation
Just wondering -- as far as I can tell, this PR is one part of unblocking rm2fb from working on newer firmware versions. Is there any explicit list of what additional work is necessary being tracked on GitHub? I'd be interested in helping, but it's not clear to me as an observer how much work is needed and of what shape. cc @ddvk |
This is not to unblock anything, just start the future proofing a known issue we will encounter. As for what is needed to support a new version: |
Note to self, after discussion with @raisjn, we've decided against incrementing the library ABI version. I'll have to undo that. It may also be worth adding support for the old configuration somehow, either with a version matrix, or by allowing old /etc/version values for OS versions up to 3.3.2.1666, and force version number for anything we support in the future. |
As /etc/version has become static in newer versions of the OS, it's no longer useful for determining what OS version the user is on. Instead,
/usr/share/remarkable/update.conf
can be parsed to determine the version number returned by the line that starts withREMARKABLE_RELEASE_VERSION=
.I've bumped the library version number to
1.0.2
1.1.0
as part of this due to how it completely breaks existing configuration. I avoided a major version bump, as the actual runtime compatibility doesn't change at all.I've also updated all references to the old
1.0.0
and1.0.1
numbers to1.1.0
1.0.2
, as well as updated the github action to run the build on pull requests.