Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-update address definitions #69

Open
matteodelabre opened this issue Aug 13, 2021 · 5 comments
Open

Auto-update address definitions #69

matteodelabre opened this issue Aug 13, 2021 · 5 comments
Assignees

Comments

@matteodelabre
Copy link
Collaborator

@Eeems suggested on Discord to make rm2fb automatically fetch the address definitions from a remote server when they are missing. This would make adapting rm2fb to new OS releases easier, since we’d just need to update the remote file and we wouldn’t need to publish new releases/package versions.

@axelson
Copy link

axelson commented Aug 13, 2021

As a user this idea makes me feel a bit uncomfortable, although I understand the reasoning behind it. Is it possible to create a setting to disable the auto-fetch feature for those that don't want it?

@Eeems
Copy link
Collaborator

Eeems commented Aug 13, 2021

As a user this idea makes me feel a bit uncomfortable, although I understand the reasoning behind it. Is it possible to create a setting to disable the auto-fetch feature for those that don't want it?

Yes it would be possible to disable it.

Ideally we'd have to put together some type of signing mechanism to ensure that it's only pulling down signature definitions that are known to be trusted. That said, due to the type of data being used here and the validation being done on the data I'd assume that it's less of a security risk.

@ClashTheBunny
Copy link

Would a package that is just data definitions be possible? If it's just additive, it could be easy to fast track release in Toltec possibly? I don't know how often they update things, but like tzdata, it could be pushed regularly without much testing?

@Eeems
Copy link
Collaborator

Eeems commented Sep 30, 2021

We would want a solution that works for both installs in Toltec, as well as users who install manually.

@Eeems
Copy link
Collaborator

Eeems commented Dec 2, 2023

It would probably make sense to just try to pull down the address definition for the specific OS version, instead of the full list each time. This would also need to have a version number gate on it to have it gracefully quit if the version of rm2fb doesn't support the address definitions required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants