Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker support #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add Docker support #9

wants to merge 2 commits into from

Conversation

Steeven9
Copy link

@Steeven9 Steeven9 commented Jan 1, 2025

This PR adds support to build and run the image in Docker

@ddries
Copy link
Owner

ddries commented Jan 1, 2025

Hi!

Thank you for your PR! I don't really see why someone would be interested in running the script inside Docker, but I think it's positive to have the option available for those who find it useful!

To be honest, I would give instructions to run the script simply with docker, not docker compose.

The "Method 3" in the README is bigger than the others ("###" vs "####").

I can do these changes myself and commit to your PR directly if you are OK with it.

@ddries ddries self-assigned this Jan 1, 2025
@Steeven9
Copy link
Author

Steeven9 commented Jan 2, 2025

That's fine with me!

Personally I run it in Docker myself since I find it easier to provision and maintain :)

@ddries
Copy link
Owner

ddries commented Jan 5, 2025

Hi,

Sorry for the delay! I will proceed with the changes then.

I like the idea of adding notification support. But personally, I don't know of Apprise. Maybe we could add support for generic webhooks? Like adding the payload and url in the config toml. I think that would be better.

@Steeven9
Copy link
Author

Steeven9 commented Jan 6, 2025

Ah shit I meant to open another PR for that... didn't realize I pushed to this branch, sorry 😅

That could work! Then in that case you can also discard my commit when you make the other changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants