-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint document and add linting step #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Do you have an automated way of linting that you could do a PR for?
I manually updated it. If I find a github action, I'll make another PR. |
I really apologize about this being all conflicted now because the other one got in there before you. If you can find a way to automate it this time even if you have to do run it manually, that may be a step forward. Note that Goland did not complain about the existing format. |
7b8304e
to
a5fb799
Compare
a5fb799
to
5d43832
Compare
I have added a "prettier" action. I set the action to lint JSON, as well as JS and MD files. Prettier is considered opinionated so you may want to change the options. (https://prettier.io/docs/en/configuration.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add instructions to the README about how to manually prettify. Thanks!
I turn Prettier off in VS Code when I’m editing Markdown because it’s too opinionated and bossy. We’ve been here before with a quick auto-formatting change wrecking intentional line breaks and adding confusion, and I’m not keen on applying this everywhere to see what breaks. (With the write option enabled, there’d also be no way to fix it!) That said, if everybody else is a fan go for it! |
I don't think the commit is going to work at all for forked PRs, so perhaps just providing the way to reformat is the way? @mattstein do you object to the actual results of prettier on this json file? |
No objection at all @rfay! |
@tyler36 I'm pretty sure the best path is to change the prettier formatting to a check instead of a commit, and then just require people to have it in that format, so the README can say how. |
Instructions added |
269a482
to
34e7f31
Compare
If we target
Currently, NOT targetting markdown. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand really why anything matters besides the remote-config.jsonc, and don't understand why this touches that file if it was already properly formatted.
This reverts commit fe83e4d.
This does seem to have trouble @tyler36 - it doesn't pass its own tests |
Yay! |
Anything else? |
We may want to grab the latest version of remote-config.jsonc. Otherwise, some of the tips will be deleted. |
Thanks for the heads up. File was synced with current tips. |
Co-authored-by: Matt Stein <[email protected]>
Co-authored-by: Matt Stein <[email protected]>
Co-authored-by: Matt Stein <[email protected]>
Thanks for all the hard work on this @tyler36 . |
This PR does some minor cleanup: