Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git): try to fix CODEOWNERS syntax #33

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix(git): try to fix CODEOWNERS syntax #33

merged 1 commit into from
Dec 23, 2024

Conversation

jonaseberle
Copy link
Collaborator

This does not seem to have worked before. It never added me, just Dave.

@jonaseberle jonaseberle requested a review from davereid as a code owner May 2, 2024 08:13
@jonaseberle
Copy link
Collaborator Author

@davereid could you give feedback if you are ok with this change?

@tyler36
Copy link

tyler36 commented Dec 23, 2024

Just a friendly ping

ping @davereid
ping @davereid-pfg (not sure if same person)

Copy link
Member

@rfay rfay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, just go ahead with it. Sometimes it's hard to get Dave.

This does not seem to have worked before. It never added me, just Dave.
@rfay
Copy link
Member

rfay commented Dec 23, 2024

Rebased.

@rfay
Copy link
Member

rfay commented Dec 23, 2024

Note that ubuntu-20.04 is going away, best to update these tests to 22.04 and 24.04 perhaps. ubuntu-latest is about to become ubuntu-24.04 as well.

@rfay rfay merged commit 6ce0ab0 into main Dec 23, 2024
3 checks passed
@rfay rfay deleted the fix/codeowners branch December 23, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants