-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapse worker into server and various refactor #153
Conversation
opened chaijs/check-error#51 as part of this, but ultimately whats happening (afaik) is something changed, possibly with vitest, where the expect'd promise rejection tests are now trigger an uncaught promise rejection, and the error was being masked |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
- Coverage 81.58% 78.29% -3.29%
==========================================
Files 179 187 +8
Lines 12466 13737 +1271
Branches 1064 1140 +76
==========================================
+ Hits 10170 10755 +585
- Misses 2296 2982 +686 ☔ View full report in Codecov by Sentry. |
caa7ae5
to
0b6ba20
Compare
For future me: All of the issues were caused by vitest and vitest-mock-axios. The vitest-mock-axios package was installing a different version of vitest, which somehow conflicts with itself (I'm guessing it patches/does codegen), which was causing the rejected promises error as well as the snapshot error. Replacing that with mock-axios-adapter and everything works as expected. More context here chaijs/check-error#51 |
🙏 |
@peated/worker
into@peated/server
defaults
andfixtures
to default fixture injection for vitest