Ubuntu fixes #86
Open
Ubuntu fixes #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os.system('mke2fs') assumes that it's installed (good bet), but also
that it works. On Ubuntu it doesn't, not with the FS sizes currently
encoded, and that leads to mystery test failures.
The straightforward way to fix this is just to raise the error where it
happens rather than silently fail; this uses asserts.
mke2fs (on Ubuntu, at least) won't create a 140k filesystem. Up the FS size to 1.4M (which, if nothing else, is old 3.5in HD floppy size).
Having changed the size of the FS formats, it's noticeable that the %-based numbers were coming out with a 0.01% error at 2dp accuracy. It appears that this is because we were using %f[:4] (which floor()s at 0.01) rather than rounding to nearest. Change code to use %.2f which does the rounding.
Recent Python versions return 'const char *' to PyUnicode_asUTF8. This can give compile errors (I was using Ubuntu 20.04's default build env). Some code changes had been made to case to 'char *', but it's dangerous to discard the const and apparently insufficient to address the warning. Update the code to make use 'const char *' variables where relevant. The warnings go away. Functionality is unaffected.
|
I am waiting on feedback for the review comments I left. If you can clean up the things I mentioned, I can merge this. |
|
@iawells @dcantrell - is the feedback added and this can be merged? I hit errors when trying to use on Ubuntu 22.04 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not so much 'fixes for Ubuntu' as 'fixes I found I needed when I tried to compile on Ubuntu'.
Nothing here changes behaviour, though one change is a change to the precise test being run (it makes a 1.4M FS rather than a 140k FS, which doesn't change the test's intent).