@newtype on array/map wrappers #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this only worked on primitive wrappers. Now you can do e.g. `foo = [* uint] ; @newtype` which was ignored before.
tests/core/input.cddl
Outdated
Comment on lines
188
to
189
| wrapper_table = { * uint => text } ; @newtype | ||
| wrapper_list = [ * uint ] ; @newtype |
There was a problem hiding this comment.
I noticed you added tests for these, but didn't actually check anywhere in the rust part of the test if these actually did anything
There was a problem hiding this comment.
Testing it compiles. The wrapper serialization code is the same as the other code tested elsewhere. I guess I should test it's even generated though.
There was a problem hiding this comment.
Added some quick ones
SebastienGllmt
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this only worked on primitive wrappers.
Now you can do e.g.
foo = [* uint] ; @newtypewhich was ignored before.