Pagination support for service_token_permissions #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-per
reviewed
Jan 28, 2025
|
|
||
| allData := make([]any, len(rawData)) | ||
| for i, data := range rawData { | ||
| err := json.Unmarshal(data, &allData[i]) |
There was a problem hiding this comment.
The acceptance test is now passing, which is great 👍 , but I am just wondering why we need to add a new unmarshalling step to the process
There was a problem hiding this comment.
Small performance tweak. We added that to try and prevent the data from needing to be marshalled and unmarshaled again by the caller (ie: 161-163 or 180-182). Might make sense to try and swap some of the other client calls over to the GetRawResponse method.
There was a problem hiding this comment.
@b-per The magic lies in Go's json.RawMessage type, so the actual data doesn't get unmarshalled just to read the pagination info.
csquire
approved these changes
Jan 28, 2025
ashtonwalden
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pagination support for service_token_permissions.
Resolves #280