Bug fix: Apply metric_time filters to time spine when needed
#1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
changed the title
courtneyholcomb
changed the title
metric_time filters to time spine when needed
courtneyholcomb
force-pushed
the
court/ts-filter3
branch
from
f658c16
to
1a060b8
Compare
courtneyholcomb
force-pushed
the
court/ts-filter3
branch
5 times, most recently
from
ad1d4bf
to
287cefa
Compare
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
courtneyholcomb
force-pushed
the
court/ts-filter3
branch
2 times, most recently
from
25a0798
to
8700c5f
Compare
courtneyholcomb
commented
Oct 15, 2024
| @@ -286,23 +296,81 @@ def _make_time_spine_data_set( | |||
| ) | |||
| # TODO: also handle date part. | |||
|
|
|||
| output_instance_set = InstanceSet( | |||
There was a problem hiding this comment.
This output instance set was incorrect before this PR, but was never used for any real logic so it didn't matter.
courtneyholcomb
force-pushed
the
court/ts-filter3
branch
8 times, most recently
from
4fa8671
to
0359853
Compare
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
requested review from
plypaul,
serramatutu,
DevonFulcher,
WilliamDee and
theyostalservice
github-actions
bot
removed
the
Run Tests With Other SQL Engines
WilliamDee
approved these changes
Oct 16, 2024
|
|
||
| # Where constraints must be applied in an outer query since they are using an alias (e.g., 'metric_time__day'), | ||
| # and some engines do not support using an alias in the WHERE clause. | ||
| if not time_spine_where_constraints: |
There was a problem hiding this comment.
nit: I always have a hard time with not x for these, it feels easier to read if we have like if len(time_spine_where_constraints) == 0
And also simplify / reorganized displayed properties for the node.
courtneyholcomb
force-pushed
the
court/ts-filter3
branch
from
0359853
to
0299f63
Compare
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a bug where, if you query a join_to_timespine metric with a metric_time filter that is not applied in the group by, you will end up with more rows than expected.
To fix that, we need to apply any metric_time filters to the time spine table before joining that table to the aggregated measure. This needs to happen before the join instead of after because after the join we may not have access to metric_time at the grain needed for the filter. This implements that behavior.
I recommend reviewing by commit.