Reduce recursive-call overhead in MetricTimeQueryValidationRule
#1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is also a common method that is called during query resolution. The memory used by the cache is small since the number of measures is on the order of ~100 in large manifests.
…n `MetricTimeQueryValidationRule`. The check in `MetricTimeQueryValidationRule` is called for every metric in a derived metric's ancestors, so this moves expensive parts of the check to only where it's needed and caches results when possible.
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
courtneyholcomb
approved these changes
Oct 2, 2024
courtneyholcomb
pushed a commit
that referenced
this pull request
Oct 9, 2024
) The check in `MetricTimeQueryValidationRule` is called for every metric in a derived metric's ancestors, so this moves expensive parts of the check to only where it's needed and caches results when possible to reduce runtimes. The signature for the validation rule classes were changed, so there are a number of diff lines related to that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check in
MetricTimeQueryValidationRuleis called for every metric in a derived metric's ancestors, so this moves expensive parts of the check to only where it's needed and caches results when possible to reduce runtimes. The signature for the validation rule classes were changed, so there are a number of diff lines related to that.