Cache additional methods in MetricLookup / SemanticModelLookup
#1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is also a common method that is called during query resolution. The memory used by the cache is small since the number of measures is on the order of ~100 in large manifests.
courtneyholcomb
approved these changes
Oct 2, 2024
| @@ -67,6 +67,9 @@ def __init__(self, model: SemanticManifest, custom_granularities: Dict[str, Expa | |||
| # Cache for defined time granularity. | |||
| self._time_dimension_to_defined_time_granularity: Dict[TimeDimensionReference, TimeGranularity] = {} | |||
|
|
|||
| # Cache for agg. time dimension for measure. | |||
There was a problem hiding this comment.
did you mean to include a period after agg?
There was a problem hiding this comment.
Yes, since it is an abbreviation.
courtneyholcomb
pushed a commit
that referenced
this pull request
Oct 9, 2024
…1438) Similar to the previous PRs, this PR caches a few additional methods. I did a little bit of memory profiling using a large manifest, and total memory allocation did not change significantly. I believe this is because these additional caches reference objects that are already stored in `ValidLinkableSpecResolver` or the cached objects have low overhead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the previous PRs, this PR caches a few additional methods. I did a little bit of memory profiling using a large manifest, and total memory allocation did not change significantly. I believe this is because these additional caches reference objects that are already stored in
ValidLinkableSpecResolveror the cached objects have low overhead.