Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache SemanticModelLookup.get_defined_time_granularity() #1437

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Oct 1, 2024

The defined time granularity of a time dimension is frequently called during query resolution to figure out the time granularity for an ambiguous group-by item.

@cla-bot cla-bot bot added the cla:yes label Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Base automatically changed from p--short-term-perf--11 to main October 2, 2024 05:37
@plypaul plypaul merged commit d507cfe into main Oct 2, 2024
10 checks passed
@plypaul plypaul deleted the p--short-term-perf--12 branch October 2, 2024 06:49
courtneyholcomb pushed a commit that referenced this pull request Oct 9, 2024
The defined time granularity of a time dimension is frequently called
during query resolution to figure out the time granularity for an
ambiguous group-by item.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants