Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved source node logic for custom granularities #1427

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Improved source node logic for custom granularities #1427

merged 2 commits into from
Sep 26, 2024

Commits on Sep 26, 2024

  1. Rename dataflow recipe -> source node recipe 

    The dataflow recipe is essentially the best choice for the source node to select from and how to join any other source nodes required to satisfy all requested specs. The name is confusing, though, since the dataflow PLAN is the entire DAG, whichextends far beyond the source nodes. Rename to source node recipe in order to make it more clear that this part of the dataflow plan is only dealing with source nodes.
    @courtneyholcomb
    courtneyholcomb committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    da6d9a2 View commit details
    Browse the repository at this point in the history

  2. Better handling for satisfying specs with base grain in dataflow plan 

    Consolidates that logic into _find_source_node_recipe() as much as possible, removes isinstance() checks, and clarifies comments.
    @courtneyholcomb
    courtneyholcomb committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    dd7eb7c View commit details
    Browse the repository at this point in the history