Add LazyFormat to reduce logging overhead on performance
#1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plypaul
force-pushed
the
p--short-term-perf--02
branch
from
5a767ab
to
390d0e5
Compare
plypaul
changed the title
LazyFormat to reduce logging performance overheadsLazyFormat to reduce logging overhead on performance
plypaul
force-pushed
the
p--short-term-perf--02
branch
from
390d0e5
to
0543e08
Compare
plypaul
force-pushed
the
p--short-term-perf--02
branch
from
0543e08
to
3595548
Compare
plypaul
force-pushed
the
p--short-term-perf--02
branch
from
3595548
to
ea66615
Compare
plypaul
force-pushed
the
p--short-term-perf--02
branch
from
ea66615
to
4a803fb
Compare
plypaul
added a commit
that referenced
this pull request
Sep 24, 2024
As per #1419, this PR updates log calls to lazily evaluate the arguments, and changes most of them to the `DEBUG` level. This way, performance in production will be improved if the log level is set to `INFO` or higher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For larger semantic manifests / queries, the overhead of formatting objects for logging / writing log lines can be significant. This adds a
LazyFormatclass can be used with the existing logger so that log messages at the debug level don't get formatted nor written when the configured log level would exclude it. Using this, a quick way to migrate the code base would be a replacement like the following: