Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL rendering tests for custom granularity time dimensions requiring join #1414

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

courtneyholcomb
Copy link
Contributor

@courtneyholcomb courtneyholcomb commented Sep 20, 2024

SQL rendering tests for querying time dimensions that require a join with custom granularity.

@cla-bot cla-bot bot added the cla:yes label Sep 20, 2024
@dbt-labs dbt-labs deleted a comment from github-actions bot Sep 20, 2024
@courtneyholcomb courtneyholcomb changed the title Court/parse custom 2 Support custom granularity for time dimensions requiring join Sep 20, 2024
@courtneyholcomb courtneyholcomb marked this pull request as ready for review September 20, 2024 19:07
@courtneyholcomb courtneyholcomb added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Sep 20, 2024
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Sep 20, 2024
@courtneyholcomb courtneyholcomb force-pushed the court/parse-custom-2 branch 2 times, most recently from 5751872 to d78a350 Compare September 24, 2024 17:22
@courtneyholcomb courtneyholcomb added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Sep 24, 2024
@courtneyholcomb courtneyholcomb changed the title Support custom granularity for time dimensions requiring join SQL rendering tests for custom granularity time dimensions requiring join Sep 24, 2024
Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Sep 24, 2024
Base automatically changed from court/parse-custom-1 to main September 24, 2024 22:10
@courtneyholcomb courtneyholcomb enabled auto-merge (squash) September 24, 2024 22:12
@courtneyholcomb courtneyholcomb merged commit 9f6af7e into main Sep 24, 2024
14 checks passed
@courtneyholcomb courtneyholcomb deleted the court/parse-custom-2 branch September 24, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants