-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQL rendering tests for custom granularity time dimensions requiring join #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
force-pushed
the
court/parse-custom-2
branch
from
September 20, 2024 18:54
e64fe1c
to
13a4e8e
Compare
courtneyholcomb
changed the title
Court/parse custom 2
Support custom granularity for time dimensions requiring join
Sep 20, 2024
courtneyholcomb
force-pushed
the
court/parse-custom-2
branch
from
September 20, 2024 19:19
6405f00
to
81cbd20
Compare
courtneyholcomb
added
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Sep 20, 2024
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
September 20, 2024 19:19
— with
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
September 20, 2024 19:19
— with
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
September 20, 2024 19:19
— with
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
September 20, 2024 19:19
— with
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Sep 20, 2024
courtneyholcomb
force-pushed
the
court/parse-custom-1
branch
from
September 24, 2024 13:53
d10ad9b
to
d85c738
Compare
courtneyholcomb
force-pushed
the
court/parse-custom-2
branch
from
September 24, 2024 13:54
81cbd20
to
05a0296
Compare
courtneyholcomb
force-pushed
the
court/parse-custom-1
branch
from
September 24, 2024 16:56
d85c738
to
630cfe7
Compare
courtneyholcomb
force-pushed
the
court/parse-custom-2
branch
2 times, most recently
from
September 24, 2024 17:22
5751872
to
d78a350
Compare
courtneyholcomb
added
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Sep 24, 2024
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
September 24, 2024 17:24
— with
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
September 24, 2024 17:24
— with
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
September 24, 2024 17:24
— with
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
September 24, 2024 17:24
— with
GitHub Actions
Inactive
courtneyholcomb
changed the title
Support custom granularity for time dimensions requiring join
SQL rendering tests for custom granularity time dimensions requiring join
Sep 24, 2024
tlento
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github-actions
bot
removed
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Sep 24, 2024
courtneyholcomb
force-pushed
the
court/parse-custom-1
branch
from
September 24, 2024 21:42
630cfe7
to
27e2c28
Compare
courtneyholcomb
force-pushed
the
court/parse-custom-2
branch
from
September 24, 2024 22:12
d78a350
to
dd1d57e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQL rendering tests for querying time dimensions that require a join with custom granularity.