SQL rendering tests for no-metric queries with custom granularity #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-7
branch
from
ebb64c0
to
7ce16d1
Compare
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-8
branch
from
46f982b
to
a418422
Compare
courtneyholcomb
changed the title
courtneyholcomb
changed the title
courtneyholcomb
changed the title
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-8
branch
from
a323af6
to
4cd0558
Compare
github-actions
bot
removed
the
Run Tests With Other SQL Engines
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-8
branch
from
4cd0558
to
fda4ac9
Compare
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-7
branch
from
7ce16d1
to
24d77fd
Compare
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-8
branch
from
fda4ac9
to
c841553
Compare
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-7
branch
from
24d77fd
to
bd5d6b1
Compare
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-8
branch
from
c841553
to
5a9baa6
Compare
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-7
branch
from
bd5d6b1
to
c6b4526
Compare
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-8
branch
from
5a9baa6
to
82dcf53
Compare
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
tlento
approved these changes
Sep 24, 2024
Comment on lines
+10
to
+18
| FROM ***************************.dim_users users_ds_source_src_28000 | ||
| CROSS JOIN | ||
| ***************************.mf_time_spine time_spine_src_28006 | ||
| LEFT OUTER JOIN | ||
| ***************************.mf_time_spine subq_11 | ||
| ON | ||
| subq_7.metric_time__day = subq_11.ds | ||
| LEFT OUTER JOIN | ||
| ***************************.mf_time_spine subq_12 |
There was a problem hiding this comment.
Oh yeah this is that thing we discussed where these queries can get weirdly redundant and expensive. Hopefully we can optimize this more easily as we restructure the dataflow plan builder around CTEs and stuff like that.
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-7
branch
from
c6b4526
to
daf40f9
Compare
courtneyholcomb
force-pushed
the
court/custom-grain-dfp-8
branch
from
82dcf53
to
d6b83dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for no-metric queries with custom granularities. Does not include tests with filters (coming later). If you have suggestions for additional no-metric scenarios that should be tested, please let me know!
Note that there is a bug in the optimization for one of these tests. I have a task to fix this up stack.