Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding entra ID sso saml migration #6779

Merged
merged 8 commits into from
Jan 17, 2025
Merged

Adding entra ID sso saml migration #6779

merged 8 commits into from
Jan 17, 2025

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Jan 15, 2025

What are you changing in this pull request and why?

Adds a new SAML 2.0 section for Entra ID in the migration guide - it moves the previous Entra ID up and Google Workspace down but these pages haven't been altered

Adds some clarifying language to the original Entra ID setup guide

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

@matthewshaver matthewshaver requested a review from a team as a code owner January 15, 2025 22:11
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jan 17, 2025 3:31pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Jan 15, 2025
@@ -113,3 +113,32 @@ You must complete the domain authorization before you toggle `Enable New SSO Aut
:::

<Lightbox src="/img/docs/dbt-cloud/access-control/azure-enable.png" title="Enable new SSO"/>

## Google Workspace
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is not new, just moved


:::
<Lightbox src="/img/docs/dbt-cloud/access-control/saml-enable-entra.png" title="Enable new SSO for SAML/Okta"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{slug} placeholder here instead of entra-id

@aaronbini
Copy link
Contributor

looks good, just needs the changes Ajay called out and then I'll approve

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion about placeholder text consistency


<Lightbox src="/img/docs/dbt-cloud/access-control/google-cloud-sso.png" title="Google Cloud Console"/>
The Entra ID fields that will be updated are:
- Single sign-on URL &mdash; `https://<YOUR_AUTH0_URI>/login/callback?connection={slug}`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this is copying what's above, but it might be worth it to use <SLUG> instead of {slug} to be consistent with our other placeholder text. Of course, you'd then need to adjust the screenshot

website/docs/docs/cloud/manage-access/auth0-migration.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ajaythomas ajaythomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewshaver added 2 change requests, and then we're good. Thanks!

@ajaythomas ajaythomas self-requested a review January 16, 2025 14:05
Copy link
Contributor

@ajaythomas ajaythomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on one of the screenshots. Can merge after that fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matthewshaver I see the slug is still docs-account for the Identifier (Entity ID) field

@matthewshaver matthewshaver enabled auto-merge (squash) January 17, 2025 15:26
@matthewshaver matthewshaver merged commit f2f1e25 into current Jan 17, 2025
8 checks passed
@matthewshaver matthewshaver deleted the sso branch January 17, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants