Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify what type of time column can be used for event_time #6760

Merged
merged 12 commits into from
Jan 13, 2025

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Jan 10, 2025

this pr adds clarification on what type of time column can be used for event_time. this stemmed from internal slack convo where we wanted to provide users with a full picture of pros/cons to using actual event time vs ingestion/loaded at time.

  • waiting for technical confirmation

🚀 Deployment available! Here are the direct links to the updated files:

@mirnawong1 mirnawong1 requested a review from a team as a code owner January 10, 2025 17:05
Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jan 13, 2025 5:27pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs labels Jan 10, 2025
@mirnawong1 mirnawong1 changed the title add considerations clarify what type of time column can be used for event_time Jan 10, 2025
@github-actions github-actions bot added the size: small This change will take 1 to 2 days to address label Jan 10, 2025
Copy link
Contributor

@joellabes joellabes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions to include another scenario and move some other text around, but this is looking much better! thanks for moving it along 🙏

website/docs/reference/resource-configs/event-time.md Outdated Show resolved Hide resolved
website/docs/reference/resource-configs/event-time.md Outdated Show resolved Hide resolved
@mirnawong1 mirnawong1 enabled auto-merge January 13, 2025 17:22
@mirnawong1 mirnawong1 merged commit 472279c into current Jan 13, 2025
8 checks passed
@mirnawong1 mirnawong1 deleted the update-event-time branch January 13, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants