-
Notifications
You must be signed in to change notification settings - Fork 989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify what type of time column can be used for event_time #6760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
Improvements or additions to content
Docs team
Authored by the Docs team @dbt Labs
labels
Jan 10, 2025
mirnawong1
changed the title
add considerations
clarify what type of time column can be used for event_time
Jan 10, 2025
github-actions
bot
added
the
size: small
This change will take 1 to 2 days to address
label
Jan 10, 2025
joellabes
requested changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggestions to include another scenario and move some other text around, but this is looking much better! thanks for moving it along 🙏
Co-authored-by: Joel Labes <[email protected]>
Co-authored-by: Joel Labes <[email protected]>
mirnawong1
commented
Jan 13, 2025
joellabes
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
content
Improvements or additions to content
Docs team
Authored by the Docs team @dbt Labs
size: small
This change will take 1 to 2 days to address
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds clarification on what type of time column can be used for
event_time
. this stemmed from internal slack convo where we wanted to provide users with a full picture of pros/cons to using actual event time vs ingestion/loaded at time.🚀 Deployment available! Here are the direct links to the updated files: