-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update description property page #6733
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiya @mirnawong1
Thanks for creating this! I've approved this for you with one non-blocking suggestion.
Kind Regards
Natalie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mirnawong1 I just had some small suggestions, but not editing/merging so you check my logic here in case I missed something.
version: 2 | ||
|
||
data_tests: | ||
- name: data_test_name | ||
description: markdown_string | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this is necessary but trying to figure out why the text turns blue here and is not respecting color coding.
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @runleonarun going to put the backticks back in bc it was rendering weird and the versionblock/tabs markdown was showing up:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Leona B. Campbell <[email protected]>
Co-authored-by: Leona B. Campbell <[email protected]>
thanks for the review @runleonarun ! made some tweaks and would love a re-review pls! |
</File> | ||
|
||
</VersionBlock> | ||
|
||
<VersionBlock lastVersion="1.8"> | ||
|
||
The `description` property is available for generic and singular data tests beginning in dbt v1.9. | ||
The `description` property is available for [singular data tests](/docs/build/data-tests#singular-data-tests) or [generic data tests](/docs/build/data-tests#generic-data-tests) beginning in dbt v1.9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[custom.Typos] Oops there's a typo -- did you really mean 'v1.9'?
columns: | ||
- name: column_name | ||
tests: | ||
- unique |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops I forgot a :
in my example. It should be:
models:
- name: orders
columns:
- name: order_id
tests:
- unique:
description: The order_id is unique for every row in the orders model
looking at the PR here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eek great flag, thanks for sharing the code @graciegoheen !
add missing :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚢 it!
this pr adds add'l examples to the description property page:
raised in internal slack
Resolves #6193
🚀 Deployment available! Here are the direct links to the updated files: