Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private packages beta #6675

Merged
merged 20 commits into from
Dec 17, 2024
Merged

Private packages beta #6675

merged 20 commits into from
Dec 17, 2024

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Dec 16, 2024 •
edited by github-actions bot
Loading

What are you changing in this pull request and why?

Beta docs for Private packages

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
  • The content in this PR requires a dbt release note, so I added one to the release notes page.

🚀 Deployment available! Here are the direct links to the updated files:

@matthewshaver matthewshaver requested a review from a team as a code owner December 16, 2024 17:29
@vercel Vercel
Copy link

vercel bot commented Dec 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Dec 17, 2024 11:29pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Dec 16, 2024
github-actions[bot]
github-actions bot reviewed Dec 16, 2024
View reviewed changes
website/docs/docs/build/packages.md Outdated

With this method, you can retrieve private packages from an integrated Git provider without any additional steps to connect.

### SSH Key Method (Command Line only)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[custom.SentenceCaseHeaders] 'SSH Key Method (Command Line only)' should use sentence-style capitalization. Try 'SSH key method command line only' instead.

github-actions[bot]
github-actions bot reviewed Dec 16, 2024
View reviewed changes
website/docs/docs/build/packages.md Outdated

With this method, you can retrieve private packages from an integrated Git provider without any additional steps to connect.

### SSH Key Method (Command Line only)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [vale] reported by reviewdog 🐶
[custom.SentenceCaseHeaders] 'SSH Key Method (Command Line only)' should use sentence-style capitalization. Try 'SSH key method command line only' instead.

mirnawong1
mirnawong1 reviewed Dec 17, 2024
View reviewed changes
website/docs/docs/build/packages.md Outdated

```yaml
packages:
- private: dbt-labs/awesome_repo
Copy link
Contributor

@mirnawong1 mirnawong1 Dec 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above comment about yaml indent

mirnawong1
mirnawong1 reviewed Dec 17, 2024
View reviewed changes
website/docs/docs/build/packages.md Outdated
- [Github](/docs/cloud/git/connect-github)
- [Azure DevOps](/docs/cloud/git/connect-azure-devops)

Support for Gitlab is coming soon.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you accept above, remember to remove this

mirnawong1
mirnawong1 requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @matthewshaver , very exciting and thank you for adding this! added some feedback here and suggestions

runleonarun
runleonarun approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one typo and small suggestion.

website/docs/docs/build/packages.md Outdated Show resolved Hide resolved
@matthewshaver matthewshaver merged commit 593feca into current Dec 17, 2024
8 checks passed
@matthewshaver matthewshaver deleted the private-packages branch December 17, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@runleonarun runleonarun runleonarun approved these changes

@mirnawong1 mirnawong1 Awaiting requested review from mirnawong1

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewshaver @runleonarun @mirnawong1