Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add batch property to model jinja fnction #6590
add batch property to model jinja fnction #6590
Changes from 2 commits
8ab28c1
92f7d48
0fc6b6d
6a1e326
831f26a
c2ccfbe
09035ec
7d8b64e
a5026ad
c61cfff
6ed90c3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 47 in website/docs/reference/dbt-jinja-functions/model.md
GitHub Actions / vale
[vale] website/docs/reference/dbt-jinja-functions/model.md#L47
Raw output
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@QMalcolm what do we mean by 'inclusive' and 'exclusive' here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mirnawong1 great question ❤️
Short answer
Inclusive means the value is included in the batch, exclusive means the value is excluded from the batch
Long answer
To think specifically about inclusivity/exclusivity means with regard to a batch, consider the batch filter statement
Things to note
event_time
toevent_time_start
used>=
with the=
part of the operator including theevent_time_start
as part of the range. This means the usage ofevent_time_start
is inclusive in the range selectionevent_time
toevent_time_end
we used<
meaning things up to, but not equal to, theevent_time_end
will be selected as part of the range. This means thatevent_time_end
is exclusive in the range selection.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh got it, thanks so much for taking the time to clarify 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We sort of state this above. Maybe we could combine the two into a callout if it's important enough