Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform connections: Add new data platform adapter for CrateDB #6564

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Nov 28, 2024

About

First things first, thanks a stack for conceiving and maintaining dbt. 💯

This patch adds information about the database adapter for the CrateDB database to dbt's documentation. Because CrateDB is compatible with PostgreSQL, it builds heavily upon the dbt-postgres adapter.

It was tremendously helpful for us to get started by gradually working through its test suite to progressively make test cases succeed on CrateDB, so we would like to explicitly send kudos to @mikealfare and all contributors.

Preview

CrateDB setup

Details

Package: https://pypi.org/project/dbt-cratedb2/
Repository: https://github.com/crate/dbt-cratedb2
Documentation: https://cratedb.com/docs/guide/integrate/dbt/

Checklist

ADDING OR REMOVING PAGES:

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@amotl amotl requested a review from a team as a code owner November 28, 2024 23:55
Copy link

welcome bot commented Nov 28, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Nov 28, 2024

@amotl is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@runleonarun runleonarun added the new contributor Label for first-time contributors label Nov 28, 2024
@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address labels Nov 28, 2024
@amotl amotl force-pushed the cratedb branch 2 times, most recently from 1c8b4ac to 9b288ca Compare November 28, 2024 23:57
@amotl amotl changed the title Documentation: Add information about database adapter dbt-cratedb2 Add information about database adapter dbt-cratedb2 Nov 28, 2024
@amotl amotl force-pushed the cratedb branch 5 times, most recently from 4f64666 to a77cf43 Compare November 29, 2024 16:21
@amotl
Copy link
Contributor Author

amotl commented Dec 5, 2024

Dear @mirnawong1 and @matthewshaver,

I just wanted to check if you need anything from my end to complete this patch, for example by improving it?

With kind regards,
Andreas.

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Dec 11, 2024 8:35pm

@mirnawong1
Copy link
Contributor

hey @amotl, thanks so much for opening this up and happy to look at this for you!

Copy link
Collaborator

@amychen1776 amychen1776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@amotl
Copy link
Contributor Author

amotl commented Dec 11, 2024

Thank you very much for the excellent guidance. 🌻

@mirnawong1
Copy link
Contributor

great stuff, thank you @amotl and @amychen1776 ! happy to merge this ?

@mirnawong1
Copy link
Contributor

hey @amotl , have enabled auto merge. any chance you can update this pr with the base branch?

auto-merge was automatically disabled December 11, 2024 17:11

Head branch was pushed to by a user without write access

@amotl
Copy link
Contributor Author

amotl commented Dec 11, 2024

@mirnawong1: Thanks. I think the job still needs attention once more. Because I am an outsider, auto-merge was disabled again.

auto-merge was automatically disabled December 11, 2024 18:11. Head branch was pushed to by a user without write access.

- Fix a typo s/specifc/specific/
- Add third variant why no documentation about platform-specific
  configuration settings is provided, by referring to vendor
  documentation pages
auto-merge was automatically disabled December 11, 2024 20:32

Head branch was pushed to by a user without write access

@mirnawong1 mirnawong1 merged commit 7b4833b into dbt-labs:current Dec 12, 2024
4 of 5 checks passed
@amotl
Copy link
Contributor Author

amotl commented Dec 12, 2024

Wonderful. We made it! Thank you again.

@amotl amotl mentioned this pull request Dec 22, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants