Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: to_columns must be an array #6451

Merged
merged 4 commits into from
Nov 11, 2024
Merged

Conversation

mnahkies
Copy link
Contributor

What are you changing in this pull request and why?

when providing a single column as a string, instead of an array, the compiled sql ends up like this:

some_id bigint not null references "database"."schema"."table" (e, x, t, e, r, n, a, l, _, i, d),

adjust the example to show an array with a single element instead.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

when providing a single column as a string, instead of an array the compiled sql ended up like this:
```
some_id bigint not null references "database"."schema"."table" (e, x, t, e, r, n, a, l, _, i, d),
```

adjust the example to show an array with a single element instead.
@mnahkies mnahkies requested a review from a team as a code owner November 10, 2024 11:31
Copy link

welcome bot commented Nov 10, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Nov 10, 2024

@mnahkies is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@runleonarun runleonarun added the new contributor Label for first-time contributors label Nov 10, 2024
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Nov 10, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @mnahkies great catch and thanks so much for opening this pr up to add this! you're absolutely right, going to merge this for you!

@mirnawong1 mirnawong1 merged commit 32fd510 into dbt-labs:current Nov 11, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants